Provisional fix for ticket #2170: regression in app events from webview on Android #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… context was broken on Android. The bindings for Ti.App in the webview had been creating a private AppModule instance to put event listeners on. This worked since each AppModule instance added itself to a list of proxies that accepted application-global events, and the AppModule had had its fireEvent() method overridden to instead dispatch events to whatever was in that list of proxies. Commit 7926eda removed that overridden fireEvent method (probably because of other changes in the framework), leaving the webview sending events just to itself. :) I changed the webview's bindings to pull up the actual live 'App' module instance instead of creating its own, so it just uses the standard event system. It appears to work in my testing updating StatusNet Mobile for the new 1.5 code; we send events back and forth between the main context and a web view to render a rich custom view, and to trigger actions from the HTML UI bits.
pingwang2011
pushed a commit
to pingwang2011/titanium_mobile
that referenced
this pull request
Jan 10, 2012
[TIMOB-6682] Fixed implementation of 2DMatrix and animate().
alexandergalstyan
referenced
this pull request
in alexandergalstyan/titanium_mobile
Apr 2, 2012
Create blackberry project Part 1
This was referenced Apr 4, 2019
This was referenced Oct 4, 2019
This was referenced Oct 14, 2019
Merged
This was referenced Oct 24, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix works for me; notes on bug at:
https://appcelerator.lighthouseapp.com/projects/32238-titanium-mobile/tickets/2170-android-regression-in-tiappfireevent-from-within-webview-context-on-15-trunk