Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(android): fix permission example for Android 8 #11236

Merged
merged 3 commits into from
Oct 15, 2019
Merged

docs(android): fix permission example for Android 8 #11236

merged 3 commits into from
Oct 15, 2019

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Sep 23, 2019 •
edited
Loading

Optional Description:

Add WRITE_EXTERNAL_STORAGE to the requestPermissions permission example so it will work on Android 8+ phones

@build build added this to the 8.3.0 milestone Sep 23, 2019
@build build requested a review from a team September 23, 2019 18:58
@build
Copy link
Contributor

build commented Sep 23, 2019 •
edited
Loading

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
⚠️

Commit ba8f441ec1ce8539bcd0edfc5eda878d5109ec93 has a message "fix" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖 ❌ 9 tests have failed There are 9 tests failing and 469 skipped out of 4591 total tests.
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Tests:

ClassnameNameTimeError
ios.Titanium.UI.LayoutTIMOB-23372 #100.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1792:33
ios.Titanium.UI.LayoutTIMOB-23372 #90.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1762:33
ios.Titanium.UI.LayoutTIMOB-23372 #80.001
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1732:33
ios.Titanium.UI.LayoutTIMOB-23372 #70.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1699:33
ios.Titanium.UI.LayoutTIMOB-23372 #60.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1654:33
ios.Titanium.UI.LayoutTIMOB-23372 #50.003
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1609:33
ios.Titanium.UI.LayoutTIMOB-23372 #40.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1566:33
ios.Titanium.UI.LayoutTIMOB-23372 #30.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1522:33
ios.Titanium.UI.LayoutTIMOB-23372 #20.002
Error: expected 9 to equal 10
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/node_modules/should/cjs/should.js:356:23
listener@file:///Users/build/Library/Developer/CoreSimulator/Devices/642A82C6-A372-44D5-87DA-40B5A9A1F6E5/data/Containers/Bundle/Application/827830E7-DB6F-4CF5-BAC3-ABC5CFBEC4A3/mocha.app/ti.ui.layout.test.js:1477:33

Generated by 🚫 dangerJS against 60b117d

drauggres
drauggres suggested changes Sep 24, 2019
View reviewed changes
garymathews
garymathews approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgtcoolguy sgtcoolguy merged commit be984a1 into tidev:master Oct 15, 2019
@sgtcoolguy
Copy link
Contributor

sgtcoolguy commented Oct 15, 2019 •
edited
Loading

BTW, we have integrated doc changes on master to an automated doc site deployment - so this change is already live at https://docs.appcelerator.com/platform/latest/#!/api/Titanium.Android (usually < 30 minutes of merge, but docker hub was down mid-day and messed it up)

@m1ga
Copy link
Contributor Author

m1ga commented Oct 15, 2019

@sgtcoolguy nice, sounds good

@m1ga m1ga deleted the docuPerm branch December 10, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drauggres drauggres drauggres requested changes

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
community 🔥 docs
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@m1ga @build @sgtcoolguy @drauggres @garymathews