Update gemika to use gh actions #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
Signed-off-by: Matthew Peveler <[email protected]>
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
commented
Jan 16, 2025
| - name: Setup | ||
| run: | | ||
| ./bin/setup | ||
| - run: bundle install |
There was a problem hiding this comment.
I removed the usage of ./bin/setup as it was installing both gemfiles, which we don't want when not using gemika imo.
The file is not referenced anymore within the repo, but wasn't sure if I should delete it as maybe someone uses it locally?
There was a problem hiding this comment.
That's a good point! I like to keep bin/setup as the no-brainer solution for getting it up and running locally.
jonatas
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #96 which migrates
gemikato use the GH action file instead of the.travis.ymlfile. The caveat here of this functioning is that:test.ymlmatrix.rubykey and your gemfiles inmatrix.gemfile(or undermatrix.includeentriesgemika(viamatrix:spec) to run the suite, instead directly using rspec, with setting gemfile bundler looks at viaBUNDLE_GEMFILEenvironment variable.