Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemika to use gh actions #98

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Update gemika to use gh actions #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bf9151
Update gemika to use gh actions
MasterOdin Jan 15, 2025
44c54e8
update workflow name
MasterOdin Jan 16, 2025
12e35cc
Only install one gemfile
MasterOdin Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml → .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ jobs:
fail-fast: false
matrix:
ruby: [ '3.1.2' ]
gemfile: [ 'Gemfile', 'Gemfile.scenic' ]
database:
- 'pg17-ts2.17-all'
- 'pg16-ts2.17-all'
- 'pg15-ts2.17-all'
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}

services:
database:
Expand All @@ -32,7 +35,7 @@ jobs:


runs-on: ubuntu-latest
name: OS Ruby ${{matrix.ruby}} database ${{matrix.database}}
name: OS Ruby ${{matrix.ruby}} (${{matrix.gemfile}}) database ${{matrix.database}}
container: ruby:${{matrix.ruby}}

steps:
Expand All @@ -54,9 +57,7 @@ jobs:
echo "SELECT version()" | psql -h database -U username testdb
echo "SELECT CURRENT_TIME" | psql -h database -U username testdb

- name: Setup
run: |
./bin/setup
- run: bundle install
Copy link
Member Author

@MasterOdin MasterOdin Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the usage of ./bin/setup as it was installing both gemfiles, which we don't want when not using gemika imo.

The file is not referenced anymore within the repo, but wasn't sure if I should delete it as maybe someone uses it locally?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point! I like to keep bin/setup as the no-brainer solution for getting it up and running locally.


- name: run tsdb
run: ./bin/tsdb postgres://username:secret@database:5432/testdb --stats
Expand All @@ -68,5 +69,5 @@ jobs:
bundle exec rake test:setup

- name: Test
run: bundle exec rake
run: bundle exec rake spec

9 changes: 0 additions & 9 deletions .travis.yml
View file
Open in desktop

This file was deleted.

Loading