connect: remove bowser dependency #7844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
connect-browser-utils
branch
4 times, most recently
from
f28d327 to
61e6cc9
Compare
mroz22
force-pushed
the
connect-browser-utils
branch
from
61e6cc9 to
ea63aa5
Compare
updatebased on discussion with @szymonlesisz and also on commit of his f28d327 which I shamelessly took and squashed we can achieve basically the same but we dont need to use |
mroz22
commented
Mar 15, 2023
mroz22
commented
Mar 15, 2023
mroz22
requested review from
tomasklim,
matejkriz,
szymonlesisz and
sime
as code owners
mroz22
commented
Mar 16, 2023
mroz22
force-pushed
the
connect-browser-utils
branch
8 times, most recently
from
993ff60 to
4e5d60e
Compare
mroz22
force-pushed
the
connect-browser-utils
branch
3 times, most recently
from
efc66e5 to
badd4d1
Compare
szymonlesisz
approved these changes
Mar 22, 2023
mroz22
force-pushed
the
connect-browser-utils
branch
from
5c04f23 to
f67ace1
Compare
szymonlesisz
approved these changes
Mar 22, 2023
|
/rebase |
trezor-ci
force-pushed
the
connect-browser-utils
branch
from
f67ace1 to
c4ede0d
Compare
mroz22
force-pushed
the
connect-browser-utils
branch
from
c4ede0d to
8176d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, stay Awhile and listen.
in #6509 I would like to use scheduleAction util which internally uses
AbortControllerwhich does not work very well in our tests, for example coinjoin package needs to usejsdomtestEnvironment where it miraculously works, but it is actually not right, we want to test such package innodeenv.My problem is similar, after doing this change in transport, all the tests in connect start to fail and I cannot really do any workarounds here. So what are my options? I could somehow tweak our jest configs, but since we are still on version 25 or which one and the latest one is 29 it feels like a waste of time to study outdated docs. So it only makes sense to update jest and see if it does not fix the problem (it does).
It is not the best situation we can have - having 2 different versions of jest in dependencies but I believe this is the only way how to update it, package per package. Last time I tried to do it globally I gave up after few horus because it comes with many problems. cc @tomasklim
You may also notice that I have created a new package called
@trezor/connect-browser-utils. There are still couple of references to browser specifics in@trezor/connectand it shouldn't be like this. That package should be pure node.js. Adding this package and doing some refactoring I was able to completly get rid ofbowserdependency from@trezor/connectwhich is good I believe. Originally, my motivation was to be able to switch testEnvironment for @trezor/connect unit tests to 'node' but I did not succeed doing this. There are still some window references elswhere...related #5319
resolve #5324
related #6025