fix(connect): fix outdated browser breaking change #8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
connect-debug-outdated
branch
from
acf84d9 to
41b6bb4
Compare
mroz22
force-pushed
the
connect-debug-outdated
branch
2 times, most recently
from
59c913e to
9ddc3b3
Compare
packages/connect-popup/src/index.tsx
Outdated
| @@ -181,6 +212,9 @@ const handleMessage = (event: MessageEvent<PopupEvent | UiEvent>) => { | |||
| // handle POPUP.INIT message from window.opener | |||
| const init = async (payload: PopupInit['payload']) => { | |||
| if (!payload) return; | |||
|
|
|||
| payload.systemInfo = getSystemInfo(config.supportedBrowsers); | |||
There was a problem hiding this comment.
if (!payload.systemInfo) maybe lets do a fallback only for missing data?
There was a problem hiding this comment.
done and forcepushed
mroz22
force-pushed
the
connect-debug-outdated
branch
from
9ddc3b3 to
1588850
Compare
szymonlesisz
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(connect-popup): enable unchained test enables tests that would have caught the bug I am fixing here now, if it was online
fix(connect-popup): systemInfo fixes broken backwards compatibility. Data used in popup to decide whether browser is outdated is now sent from the code that is part of npm package, this means that unless update, this data is missing in popup.html.
QA testing tips: