Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: Align estimateGas error with others #502

Merged
merged 2 commits into from
Nov 25, 2019
Merged

fix: Align estimateGas error with others #502

merged 2 commits into from
Nov 25, 2019

Conversation

davidmurdoch
Copy link
Member

Fixes #480

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 82.115% when pulling cc54875 on fix/estimateGasErrorResponse into 5844921 on develop.

@PhABC
Copy link

PhABC commented Nov 18, 2019

Any update on this PR? 🙏

nicholasjpaterno
nicholasjpaterno approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @davidmurdoch!

@davidmurdoch davidmurdoch merged commit 28fe616 into develop Nov 25, 2019
@nicholasjpaterno nicholasjpaterno deleted the fix/estimateGasErrorResponse branch December 2, 2019 18:49
This was referenced Dec 18, 2019
Closed
Merged
@mickys mickys mentioned this pull request Dec 20, 2019
Merged
@renovate renovate bot mentioned this pull request May 27, 2021
Open
1 task
This was referenced Jun 6, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicholasjpaterno nicholasjpaterno nicholasjpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM Revert Reasons not returned
4 participants
@davidmurdoch @coveralls @PhABC @nicholasjpaterno