Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

VM Revert Reasons not returned #480

Closed
BrendanChou opened this issue Aug 30, 2019 · 3 comments · Fixed by #502
Closed

VM Revert Reasons not returned #480

BrendanChou opened this issue Aug 30, 2019 · 3 comments · Fixed by #502

Comments

@BrendanChou
Copy link

BrendanChou commented Aug 30, 2019

Revert reasons are not being passed back by ganache-core anymore

Expected Behavior

Old error.message (v6.4.1)
Returned error: VM Exception while processing transaction: revert ${solidityRevertReason}

Current Behavior

error.message being passed back (v6.7.0-beta.0)
error: execution error: revert

Possible Solution

Steps to Reproduce (for bugs)

Send a transaction that reverts with a solidity revert string.

Your Environment

"truffle": "5.0.34",
"ganache-cli": "6.7.0-beta.0",
@BrendanChou BrendanChou changed the title "message": "execution error: revert" VM Revert Reasons not returned Aug 30, 2019
@BrendanChou
Copy link
Author

This seems to be a problem in estimate gas. Investigating further

@davidmurdoch
Copy link
Member

Previously, estimate gas was incorrectly returning estimates for failing transactions instead of failing (like other clients do). We'll look into providing the revert reason string to the error message in estimate gas. /cc @nicholasjpaterno

@e00dan
Copy link

e00dan commented Dec 18, 2019

Is there a plan to release #502 any soon?

cc @davidmurdoch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants