fixed pr #95 #96
Merged
fixed pr #95 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOD:delete the buildPath code and use k8s native. And add a configGetter struct.
FIX:fix the headless service forward twice bug
…or windows shell. Why: the old way of accessing "\\\\.\\PHYSICALDRIVE0" may not work on every system, because.. what if I don't have that folder? (clearly my case :D ) Ref for the new way: golang/go#28804
Correct/universal way to detect if we're using an administrator windows shell
…he watting for pod running.
…listWatcher, and add update to readme
…t the service forward
…t pod as service name
… change some channel
|
@cjimti |
D3-LucaPiombino
pushed a commit
to CodeCoil/kubefwd
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed for pr #95
the bug is cause by
i forget to pass the opts.namespace as a args here and use "default" instead.
i have added a namespace setting in test and fixed it.