Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up missing-apis.txt for 2.0.0-beta2 #6169

Open
Manishearth opened this issue Feb 20, 2025 · 0 comments · May be fixed by #6186
Open

Clean up missing-apis.txt for 2.0.0-beta2 #6169

Manishearth opened this issue Feb 20, 2025 · 0 comments · May be fixed by #6186
Assignees
@Manishearth @robertbastian
Milestone
ICU4X 2.0 Beta 2 ...

Comments

@Manishearth
Copy link
Member

Everything except for datetime should be clean. Datetime FFI may not hit 2.0-beta2.

@robertbastian to figure out timezones, @Manishearth to do everything else.
@Manishearth Manishearth added this to the ICU4X 2.0 Beta 2 ⟨P1⟩ milestone Feb 20, 2025
@Manishearth Manishearth mentioned this issue Feb 21, 2025
Merged
Manishearth added a commit that referenced this issue Feb 24, 2025
@Manishearth
Add all missing properties FFI APIs (#6177)
0faaaac 
Part of #6169


Adds:

- `rust_link` for to/from ICU4X APIs. Rename them a bit. I am _not_
renaming them to have icu4c in their name because in the context of
ICU4X FFI the property integers are not just useful for ICU4X: they're
useful for CodePointMapData (which does not return typed values)
- `for_char` convenience APIs over FFI, providing a no-alloc way to get
properties
- `long_name` and `short_name` APIs, only in compiled data mode. We can
add a separate data loading path if requested
- Bidi convenience properties, only in compiled data mode. We can add a
separate data path if requested, again.


<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.9
-->
@Manishearth Manishearth linked a pull request Feb 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

@robertbastian robertbastian

Labels
None yet
Projects
None yet
Milestone
ICU4X 2.0 Beta 2 ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

Add PluralRules FFI APIs and rust_links Manishearth/icu4x
2 participants
@Manishearth @robertbastian