Add all missing properties FFI APIs #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can be re-renamed when unicode-org#6067 is fixed, if desired.
Manishearth
force-pushed
the
props-ffi-1
branch
from
5b066a8 to
b117bb3
Compare
Manishearth
force-pushed
the
props-ffi-1
branch
from
b117bb3 to
a00721b
Compare
Manishearth
force-pushed
the
props-ffi-1
branch
from
a00721b to
51b16d4
Compare
Manishearth
changed the title
Manishearth
force-pushed
the
props-ffi-1
branch
from
51b16d4 to
9515892
Compare
| } | ||
| #[diplomat::rust_link(icu::properties::props::BidiClass::to_icu4c_value, FnInStruct)] | ||
| /// Convert to an integer value usable with ICU4C and CodePointMapData | ||
| pub fn to_integer_value(self) -> u8 { |
There was a problem hiding this comment.
should we use the same names?
Suggested change
| pub fn to_integer_value(self) -> u8 { | |
| pub fn to_icu4c_value(self) -> u8 { |
There was a problem hiding this comment.
No, I explained why in the PR body:
I am not renaming them to have icu4c in their name because in the context of ICU4X FFI the property integers are not just useful for ICU4X: they're useful for CodePointMapData (which does not return typed values)
| pub fn from_integer(other: u8) -> Option<Self> { | ||
| #[diplomat::rust_link(icu::properties::props::BidiClass::from_icu4c_value, FnInStruct)] | ||
| /// Convert from an integer value from ICU4C or CodePointMapData | ||
| pub fn from_integer_value(other: u8) -> Option<Self> { |
There was a problem hiding this comment.
Suggested change
| pub fn from_integer_value(other: u8) -> Option<Self> { | |
| pub fn from_icu4c_value(other: u8) -> Option<Self> { |
robertbastian
previously approved these changes
Feb 24, 2025
|
Hm, we're going to have a bit of a conflicty time with all these FFI PRs. Oh well. |
robertbastian
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6169
Adds:
rust_linkfor to/from ICU4X APIs. Rename them a bit. I am not renaming them to have icu4c in their name because in the context of ICU4X FFI the property integers are not just useful for ICU4X: they're useful for CodePointMapData (which does not return typed values)for_charconvenience APIs over FFI, providing a no-alloc way to get propertieslong_nameandshort_nameAPIs, only in compiled data mode. We can add a separate data loading path if requested