Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typing env vars #4989

Merged
merged 2 commits into from
Sep 21, 2021
Merged

docs: typing env vars #4989

merged 2 commits into from
Sep 21, 2021

Conversation

ar7casper
Copy link
Contributor

Description

Doing what's written in the current documentation doesn't work.
Updating it to the suggested version works great.
I think it also resolves - #4928

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ar7casper ar7casper changed the title Updated docs on how to cope with typing env vars docs: Updated docs on how to cope with typing env vars Sep 19, 2021
@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Sep 20, 2021
@ar7casper
Copy link
Contributor Author

@Shinigami92 added.

@patak-dev patak-dev changed the title docs: Updated docs on how to cope with typing env vars docs: typing env vars Sep 21, 2021
@patak-dev patak-dev merged commit 8926c96 into vitejs:main Sep 21, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Sep 22, 2021
@ar7casper @Shinigami92
docs: typing env vars (vitejs#4989)
91c5398 
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Alex Raihelgaus <[email protected]>
rodydavis pushed a commit to rodydavis/vite that referenced this pull request Sep 25, 2021
@ar7casper @Shinigami92 @rodydavis
docs: typing env vars (vitejs#4989)
dc11c61 
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Alex Raihelgaus <[email protected]>
rodydavis pushed a commit to rodydavis/vite that referenced this pull request Sep 25, 2021
@ar7casper @Shinigami92 @rodydavis
docs: typing env vars (vitejs#4989)
eb73956 
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Alex Raihelgaus <[email protected]>
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@ar7casper @Shinigami92 @aleclarson
docs: typing env vars (vitejs#4989)
dadf987 
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Alex Raihelgaus <[email protected]>
@N0tExisting N0tExisting mentioned this pull request Jan 17, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ar7casper @Shinigami92 @patak-dev