Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(env-and-mode): use Module Augumentation for ImportMetaEnv #6540

Closed
wants to merge 1 commit into from

Conversation

N0tExisting
Copy link

Description

As described in #2773 and improved in #4989 you can extend import.meta.env and this PR tries to improve the extension even further, by using module augmentation, which avoids a lot of potential issues.

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the documentation Improvements or additions to documentation label Jan 19, 2022
@bluwy
Copy link
Member

bluwy commented Apr 12, 2022

The existing style showed in the docs had worked well for me. Can you elaborate what potential issues this new method helps avoid?

@bluwy
Copy link
Member

bluwy commented Feb 24, 2023

Closing as the one mentioned in the docs currently works.

@bluwy bluwy closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants