Fix #57 -- SmartyPants handling of single quotes.

[mmorearty]

git bisect indicates that the single quote bug was introduced in commit ad2c7fe. The problem is that by the time quotation marks are being converted, ' has already been changed into ', and the code to convert that into a smart quote is only looking for ', not &#39.

There was already code to handle the fact that " had been converted into ", but it appears that single-quotes were overlooked.

[mmorearty]

Hang on please, there is a bug in this pull request that I need to fix...

[mmorearty]

Okay, it's good to go

[aprescott]

Your branch has a broken rake for me:

git clone https://github.com/mmorearty/redcarpet.git
cd redcarpet
git checkout patch-single-quotes
bundle install
rake

mkdir -p tmp/x86_64-linux/redcarpet/1.9.3
cd tmp/x86_64-linux/redcarpet/1.9.3
/home/adam/.rvm/rubies/ruby-1.9.3-p286/bin/ruby -I. ../../../../ext/redcarpet/extconf.rb
creating Makefile
cd -
cd tmp/x86_64-linux/redcarpet/1.9.3
make
compiling ../../../../ext/redcarpet/html_smartypants.c
../../../../ext/redcarpet/html_smartypants.c: In function ‘squote_len’:
../../../../ext/redcarpet/html_smartypants.c:94:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
../../../../ext/redcarpet/html_smartypants.c:94:2: note: use option -std=c99 or -std=gnu99 to compile your code
make: *** [html_smartypants.o] Error 1
rake aborted!
Command failed with status (2): [make...]
/home/adam/.rvm/gems/ruby-1.9.3-p286/gems/rake-compiler-0.8.1/lib/rake/extensiontask.rb:112:in `block (2 levels) in define_compile_tasks'
/home/adam/.rvm/gems/ruby-1.9.3-p286/gems/rake-compiler-0.8.1/lib/rake/extensiontask.rb:111:in `block in define_compile_tasks'
Tasks: TOP => default => test => test:unit => compile => compile:x86_64-linux => compile:redcarpet:x86_64-linux => copy:redcarpet:x86_64-linux:1.9.3 => tmp/x86_64-linux/redcarpet/1.9.3/redcarpet.so
(See full trace by running task with --trace)

[aprescott]

Same error when trying to install the built gem:

Building native extensions.  This could take a while...
ERROR:  Error installing redcarpet-2.2.2.gem:
    ERROR: Failed to build gem native extension.

        /home/adam/.rvm/rubies/ruby-1.9.3-p286/bin/ruby extconf.rb
creating Makefile

make
compiling buffer.c
compiling rc_render.c
compiling html.c
compiling stack.c
compiling markdown.c
compiling rc_markdown.c
compiling autolink.c
compiling html_smartypants.c
html_smartypants.c: In function ‘squote_len’:
html_smartypants.c:94:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
html_smartypants.c:94:2: note: use option -std=c99 or -std=gnu99 to compile your code
make: *** [html_smartypants.o] Error 1


Gem files will remain installed in /home/adam/.rvm/gems/ruby-1.9.3-p286/gems/redcarpet-2.2.2 for inspection.
Results logged to /home/adam/.rvm/gems/ruby-1.9.3-p286/gems/redcarpet-2.2.2/ext/redcarpet/gem_make.out

[mmorearty]

That's weird; I have no idea why I didn't hit that compile error sooner. Sorry; fixed.

[aprescott]

Looks good. I built a 2.2.2.quotes version of the gem and installed it, looks like it solves the bug, at least, as well as handling ' even in HTML:

Redcarpet::Markdown.new(Redcarpet::Render::SmartyHTML).render("<p>testing's &#39;quote&#39;s and <code>code's code</code></p>")
#=> "<p>testing&rsquo;s &lsquo;quote&rsquo;s and <code>code's code</code></p>\n"

[jamieholst]

+1

[robin850]

@mmorearty : Could you rebase your commit please? 😄 I can't merge it automatically. If you want me to do it manually, let me know. It looks good to me. Thanks a lot!

[robin850]

@mmorearty : Sorry it was a merge conflict, your commits were correctly squashed ; I allow myself to merge it locally. Thanks a lot for this contribution!

[mmorearty]

Great, thanks @robin850 !