Conglomerate of PRs with tests #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed unit tests * Defaults to empty array of groups to provide safer defaults
* `service_config_perms` can now be passed as a class parameter * Added spec tests
…string * various community variable can now be either arrays or strings * various network variables can now be either arrays or strings * simplified template for snmpd.conf using ruby magic
| rwcommunity6 <%= @rw_community6 %> <%= @rw_network6 %> | ||
| <% end -%> | ||
| <% end -%> | ||
| <%- [*@ro_community].compact.each do |c| -%> |
There was a problem hiding this comment.
The [*@ro_community] syntax will take a variable and convert it into an array if it is not already. This allows us to really trim down this file.
|
Awesome work @jrwesolo . If I could ask one favour: could you resubmit against the |
|
Sure thing! #62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this module and saw a few open pull requests that seem to have been abandoned by their submitters. I went ahead and implemented some of the changes, complete with tests, for the following PRs: #29, #43, #49.
Highlights
service_config_permsto be a class parameterinitclass