Conglomerate of PRs with tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@razorsedge How's this look? I made the modifications you requests with #61. |
|
@razorsedge Does this need anything else before you can merge it in? |
|
@jrwesolo Those "Merge branch" commits should not be in there. Did you fork from |
|
Also, I am not a fan of PR#43, as it changes long-standing defaults without documenting them. I fail to see how it helps prevent DDoS. |
|
Yes, I branched from master. Let me clean that up and do some quick research about PR#43. If I can find a good reason for it, I'll get that info to you. Otherwise, I'll remove that. Standby. |
* service_config_perms can be passed as a parameter now * Network and community parameters can be strings or array * Simplified snmpd.conf.erb template logic * Validate additional arrays * Spec tests to cover changes
jrwesolo
force-pushed
the
pr-conglomerate-fix
branch
from
be5e618 to
2030aa8
Compare
|
@razorsedge Should be good now. I cleaned up the commits and removed the stuff from #43. |
|
Version 3.6.0 released to the Forge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this module and saw a few open pull requests that seem to have been abandoned by their submitters. I went ahead and implemented some of the changes, complete with tests, for the following PRs: #29, #43, #49.
Highlights
Change default groups to be empty, prevent DDoSservice_config_permsto be a class parameterinitclass