Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set -x FORGIT_INSTALL_DIR causing fish to cd into config dir on startup #165

Closed
6 of 10 tasks
petertriho opened this issue Oct 22, 2021 · 6 comments
Closed
6 of 10 tasks

set -x FORGIT_INSTALL_DIR causing fish to cd into config dir on startup #165

petertriho opened this issue Oct 22, 2021 · 6 comments

Comments

@petertriho
Copy link
Contributor

petertriho commented Oct 22, 2021 •
edited
Loading

Check list

  • I have read through the README
  • I have the latest version of forgit
  • I have searched through the existing issues

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

Looks like these changes #164, specifically

forgit/conf.d/forgit.plugin.fish

Line 15 in eb6db72

set -x FORGIT_INSTALL_DIR (cd (dirname (dirname (status -f))); and pwd)
is causing fish to start up in ~/.config/fish
@petertriho
Copy link
Contributor Author

petertriho commented Oct 22, 2021 •
edited
Loading

I'm not sure what path FORGIT_INSTALL_DIR should be but
set -x FORGIT_INSTALL_DIR (dirname (dirname (status -f)) seems to effectively be the same thing without needing to cd

@wfxr
Copy link
Owner

wfxr commented Oct 25, 2021

@petertriho Thank you reporting this bug. I reverted this change temporarily in a047bae.

FORGIT_INSTALL_DIR is used for git aliases support. I'm not familiar with fish. I wonder how to execute (cd (dirname (dirname (status -f))); and pwd) in a fish's sub shell so that it will not change the current PWD?

@petertriho
Copy link
Contributor Author

@wfxr I believe set -x FORGIT_INSTALL_DIR (dirname (dirname (status -f)) will work

@wfxr
Copy link
Owner

wfxr commented Oct 26, 2021

@wfxr I believe set -x FORGIT_INSTALL_DIR (dirname (dirname (status -f)) will work

@petertriho Thank you ! Would you like to send a pr ?

@petertriho
Copy link
Contributor Author

@wfxr Done!

@wfxr wfxr closed this as completed Oct 26, 2021
@cjappl cjappl removed their assignment Oct 28, 2021
@cjappl
Copy link
Collaborator

cjappl commented Oct 28, 2021

Thank you!!

ethan605 pushed a commit to ethan605/forgit that referenced this issue Jan 29, 2022
@petertriho
fix: restore setting FORGIT_INSTALL_DIR in fish wfxr#165
2d10abe
ethan605 pushed a commit to ethan605/forgit that referenced this issue Jan 29, 2022
@petertriho @ethan605
fix: restore setting FORGIT_INSTALL_DIR in fish wfxr#165
cd88d44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wfxr @petertriho @cjappl