-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to use forgit commands as sub-commands of git (e.g. git forgit log
)
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an underscore instead of a dash simplifies the workflow and documentation by making the commands and environment variables that forgit uses the same (i.e. `git forgit checkout_file` is the same command referred to by `forgit_checkout_file`)
wfxr
reviewed
Oct 20, 2021
@wren Merged. Thanks again for your contirbution ! |
10 tasks
p00f
reviewed
Oct 22, 2021
ethan605
pushed a commit
to ethan605/forgit
that referenced
this pull request
Jan 29, 2022
This reverts commit 950a735.
ethan605
pushed a commit
to ethan605/forgit
that referenced
this pull request
Jan 29, 2022
This reverts commit 950a735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
Fixes #147
This works by adding a file (
bin/git-forgit
) that acts as a bridge between forgit and git. The file takes any command, changes underscores to double colons (_
→::
), and forwards all arguments to the associated function inforgit.plugin.zsh
. For example,git forgit log
becomesforgit::log
, andgit forgit checkout_file README.md
becomesforgit::checkout::file README.md
.This file should be future-proof as long as the current naming scheme continues, so it won't need to be updated every time a new command is added.
Also, this relies on the user setting an environment variable named
FORGIT_STANDALONE
. All new code in forgit is hidden behind this new flag, so no current users will see any change in behavior or performance when updating forgit.Type of change
Test environment