chore(db): Add missing github-slugger dependency & tests

[43081j]

Changes

This wasn't building locally thanks to github-slugger missing from the dependencies.

I've added it to the package, and a couple of tests while I was in there.

Testing

New unit tests were added (though unrelated to github-slugger)

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 2375ce7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[lilnasy]

Looks great to me! Thanks for fixing it. I addressed the merge conflicts.

The changes seem obvious, but I'm surprised this wasn't an issue before. It may have to do with the specific package manager you use.

@43081j Could you share the error and the package manager it occurs with?

[ematipico]

Yeah, this issue was completely unsound, but the package must be added. Thank you for fixing this

[43081j]

i didn't do anything odd in particular, i basically did a clean clone then pnpm i at the root and ran a build

i was using node v21, and pnpm 8.15.5 iirc

i'll try again locally later today if i can, to be sure it was those versions

[43081j]

just tried it on my macbook (was on WSL on windows before i think), with a clean clone

pnpm i
pnpm run build

@astrojs/db:build: src/core/cli/commands/link/index.ts:4:22 - error TS2307: Cannot find module 'github-slugger' or its corresponding type declarations.

node 21.7.1
pnpm 8.15.5

[43081j]

have done the PR comments FYI 👍

let me know if all is good

[bholmesdev]

Surprised we got this far without catching... must have unsafely resolved from an Astro core dependency. Thanks for catching!