Fix integrations absolute links and changelog generation errors #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
delucis
reviewed
Jan 4, 2023
delucis
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Lots of links to other docs pages and local links (those starting with
#) were being wrongly prepended by theabsoluteLinksremark plugin. I couldn't find a reason as to why theabsoluteLinksremark plugin exists in the first place, taking a look at #954, I guess it was fixing something related to Markdown footnotes (maybe we can remove it?). Changed a line to make it ignore the links I didn't want it to change, but perhaps this can cause another problem. - I did some tests and couldn't find any broken links from the change in the remark plugin.Additionally, I found out the Alpine.js integration changelog wasn't being deleted, so I made a small change to ensure its deletion as well.