-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official integration READMEs to docs #954
Conversation
Using npm means waiting for updates to be published — this allows to always have the latest (including my most recent fixes)
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Sarah Rainsberger <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
We LOVE details, as a concept. 💜 I know we originally wondered, "Should INSTALL instructions be hidden behind details? Isn't that kind of a DON'T HIDE thing?" At the time, it was possible to install these integrations through I'm going to say loud +1 on detailing away at the very least manual install instructions. We shouldn't really need them soon (and at least in tailwind doc, |
@delucis This looks fantastic! Now that we have all this, I think at a minimum, here are some quick changes to make to the main Integrations page in docs:
|
@delucis All these changes LGTM! There is one failing test I've been chatting to @hippotastic about, but we think it's non-blocking. This is all yours when you're happy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Looks great, added a few FYI notes along the way but nothing blocking a merge
Can't wait to see these pages live!
You can find many integrations developed by the community in the [Astro Integrations Directory](https://astro.build/integrations/). Follow links there for detailed usage and configuration instructions. | ||
|
||
:::note[Experimental status] | ||
**To enable third-party integrations:** Run Astro with the `--experimental-integrations` CLI flag, or include `experimental: { integrations: true }` in your Astro config file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May already be tracked elsewhere, but I'm pretty sure we'll be getting rid of the experimental
flag as part of the 1.0 release candidate
What kind of changes does this PR include?
Description
To do
<details>
?Do we need to tag these specially in the integration READMEs? ADone by assuming all of these start with a link tohide-in-docs
class or something?#why...
<details>
styling