[CollectionView] UWP- Updating the ItemsLayout type should refresh the layout #10316
Conversation
…onInfo.DeviceFamily UWP-Xbox sets TV...Surface tablets sets Desktop intead of Phone
Default was changed to be Unsupported Idiom Co-Authored-By: EmilAlipiev <[email protected]>
Co-Authored-By: EmilAlipiev <[email protected]>
upda from origin master
EmilAlipiev
changed the title
|
can we get this fix? if anyone can review and accept it? it is so important for uwp :) |
update from master
|
Can we get this fix merged please? This bug makes collectionview not usable for uwp. |
There was a problem hiding this comment.
Thanks for the PR @EmilAlipiev.
I've done some tests. The ItemsLayout change works (see other comments) but we also need a small change in ItemContentControl to force a Measure of the content.
| @@ -186,6 +186,25 @@ protected override void HandleLayoutPropertyChanged(PropertyChangedEventArgs pro | |||
| break; | |||
| } | |||
| } | |||
| else if (property.Is(StructuredItemsView.ItemsLayoutProperty)) | |||
There was a problem hiding this comment.
Changing the ItemsLayout used, switch between FormsListView and FormsGridView with the appropriate container in ItemsViewRenderer.cs, this block is not necessary.
|
Hi @jsuarezruiz thanks for your reply. I have just checked your PR. it looks a bit different than mine. If you think that your one resolves the issue better i dont mind, please go ahead. I was just trying my best since nobody picked up this issue almost a year :) For me the most important thing is that we can use collectionview on uwp ;) |
|
@EmilAlipiev I understand it and I really appreciate the effort, thanks!. We want the same, allow you use CollectionView in UWP without problems. If you complete the PR, I will be happy to review/help with it, etc. |
|
@jsuarezruiz ok i applied your changes and pushed. please go ahead :) i hope to see this fix merged soon. |
|
@jsuarezruiz what is that conflict now? Do you have any idea how we can resolve it? |
|
Hi @EmilAlipiev i fixed the conflict but seems the branch is not correct, there are changes to files that are not needed. Like FormsProgressBar. Maybe is better to branch master, cherry-pick the commits you want and force push this branch again |
|
Hi @rmarinho yes, i made a mistake yesterday and worked on another issue without creating a new branch. i have recognized after i pushed them. i need to separate them to a new branch. It is the confusion of working in a fork branch :) |
|
@EmilAlipiev please open a new pr when ready. Thanks |
|
@rmarinho Should I open another PR for ProgressRing changes do you mean? I am bit confused here because when I look at the origin/master history, it shows my commit was merged. Is there something I am missing here?
|
|
@EmilAlipiev this PR shows changes to the ProgressRing , but the title refers to ItemsLayout and CollectionView. |
This is an update to this issue. It was closed with fix for Android and IOS but UWP wasnt working.
I have tried my best to fix the issue. I am not sure if that is the best way of fixing this. But it works fine. I didnt create a new test case because existing case 5354 can be used and it works fine like that.