Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

PB-380: split get_logger() #242

Merged

Conversation

little-dude
Copy link
Contributor

@little-dude little-dude commented Jan 29, 2020

References

https://xainag.atlassian.net/browse/PB-380

Summary

get_logger() does not just create a logger and wrap it into
structlog. It actually also creates an "aimetrics" logger and
reconfigures structlog. This commit split get_logger() so that it
only creates a logger.


Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

Summary:

`get_logger()` does not just create a logger and wrap it into
structlog. It actually also creates an "aimetrics" logger and
reconfigures structlog. This commit split `get_logger()` so that it
only creates a logger.

References:

https://xainag.atlassian.net/browse/PB-380
Copy link
Member

@PanicButtonPressed PanicButtonPressed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. Probably @Robert-Steiner can also have a look at it.

Copy link
Contributor

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@little-dude little-dude merged commit c4dfeb6 into xaynetwork:development Jan 30, 2020
@little-dude little-dude deleted the PB-380-split-get_logger branch January 30, 2020 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants