Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

PB-381: make the log level configurable #243

Merged

Conversation

little-dude
Copy link
Contributor

@little-dude little-dude commented Jan 29, 2020

This is based on #242


References

https://xainag.atlassian.net/browse/PB-381

Summary

Add a new [logging] section to the configuration file. For now, this
section only provides a level key which can be one of the log levels
supported by default by the Python standard library: notset, debug,
info, warning, error, critical.

In the future, this [logging] section could be used to provide more
knobs for logging customatization: enabling colors for the terminal
handler, specifying a path for logging into a file, etc.

References:

xainag.atlassian.net/browse/PB-381


Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

@little-dude little-dude force-pushed the PB-381-customize-log-level branch from 7ec6b3a to 054b379 Compare January 29, 2020 15:46
@little-dude little-dude changed the title Pb 381 customize log level PB-381 customize log level Jan 29, 2020
@little-dude little-dude force-pushed the PB-381-customize-log-level branch from 054b379 to 0026600 Compare January 30, 2020 09:03
@little-dude little-dude requested a review from wilk10 January 30, 2020 11:53
Robert-Steiner
Robert-Steiner previously approved these changes Jan 30, 2020
Summary:

Add a new `[logging]` section to the configuration file. For now, this
section only provides a `level` key which can be one of the log levels
supported by default by the Python standard library: notset, debug,
info, warning, error, critical.

In the future, this `[logging]` section could be used to provide more
knobs for logging customatization: enabling colors for the terminal
handler, specifying a path for logging into a file, etc.

References:

https://xainag.atlassian.net/browse/PB-381
@little-dude little-dude changed the title PB-381 customize log level PB-381: make the log level configurable Jan 30, 2020
@little-dude little-dude merged commit 03e0453 into xaynetwork:development Jan 30, 2020
@little-dude little-dude deleted the PB-381-customize-log-level branch January 30, 2020 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants