Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop → master merge for 1.4.4 #738

Merged
merged 24 commits into from
Feb 13, 2023
Merged

Develop → master merge for 1.4.4 #738

merged 24 commits into from
Feb 13, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Feb 10, 2023

No description provided.

CompatHelper Julia and others added 22 commits January 25, 2023 01:40
…23-01-25-01-40-12-626-04217619253

CompatHelper: bump compat for SBML to 1, (keep existing compat)
triggered by @exaexa on PR #732
> Originally, Seth was a sky god, lord of the desert, master of storms,
> disorder, and warfare -- in general, a trickster. Set embodied the necessary
> and creative element of violence and disorder within the ordered world.
fix GRA compat once more (and hopefully the last time)
@exaexa exaexa requested a review from stelmo February 10, 2023 09:07
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@exaexa
Copy link
Collaborator Author

exaexa commented Feb 10, 2023

We'll need to wait for the mac tests to pass here, might take a while. Probably on monday.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 91.30% // Head: 91.34% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (28ddfbd) compared to base (2485f84).
Patch coverage: 97.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   91.30%   91.34%   +0.04%     
==========================================
  Files          82       82              
  Lines        2208     2196      -12     
==========================================
- Hits         2016     2006      -10     
+ Misses        192      190       -2     
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (ø)
src/base/types/SBMLModel.jl 92.75% <ø> (ø)
src/base/types/StandardModel.jl 100.00% <ø> (ø)
src/base/utils/gene_associations.jl 97.87% <97.67%> (+2.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit 4927191 into master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants