[Localization] Localize arena-tag messages & texts #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables
Co-authored-by: Jannik Tappert <[email protected]>
this also reduces output noise in tests
Co-authored-by: lnuvy <[email protected]>
Co-authored-by: lnuvy <[email protected]>
* Localization(pt): translated bgm-name.ts * fix
[QoL] Add Discord and Google Login
…gging [Feature][ENV] make i18n debugging an optional env setting
* Update TMs for more Indigo Disk changes * Fix typo, more Stored Power
* Refactor challenges and add fresh start * Add achievement for fresh start challenge
* Fix random damage roll to be 85-100% instead of 85-99% * Update battle.test.ts to reflect the fix
* [Help] [Move/Bug] Patches Psychic Terrain applicability edge cases Was cancelling moves even if targeted mons weren't on the terrain. * [Bug `]Pokemon.isGrounded` does not exist Replaced with `Pokemon.isGrounded()`, which does. * [Bug] Psychic Terrain priority move cancel ignoring ungrounded * [Bug] Semi-invulnerable should not be grounded
* Prevent sizing error * Make reboot not necessary for show BGM * Makes the BGM Bar active by default + It had originally been decided that this would not be active by default because it was to be displayed outside the pause menu, but since its behavior has changed between this decision and its integration, the default deactivation is no longer necessary
…s#2254 (pagefaultgames#2906) * Translate forgotten sentences on phases * Translate to de forgotten sentences on phases * Translate to es forgotten sentences on phases * Translate to fr forgotten sentences on phases * Translate to it forgotten sentences on phases * Translate to ko forgotten sentences on phases * Translate to pt br forgotten sentences on phases * Translate to zh cn forgotten sentences on phases * Translate to zh tw forgotten sentences on phases * remove duplicate message * remove duplicate message * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update battle.ts [Localization(it)] * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]>
…ltgames#2907) * Translate pokemon summary * Translate pokemon summary to fr * Translate pokemon summary to de * Translate pokemon summary to es * Translate pokemon summary to it * Translate pokemon summary to ko * Translate pokemon summary to pt br * Translate pokemon summary to zh cn * Translate pokemon summary to zh tw * Fix import * Update partially for en and ko * Update interface name for en * Merge trainerLabel&Text and calculate typeLabel width * Update src/locales/es/pokemon-summary.ts Co-authored-by: GoldTra <[email protected]> * Apply translations key to all languages with interface TranslationEtries * Update ko/translationKey of status * Update ko/translationKey of pokemonInfo * Update de/translationKeys of memostring and metFragment * Update de/translationKeys of memostring and metFragment 2 * Update src/locales/ko/pokemon-summary.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/pokemon-summary.ts Co-authored-by: returntoice <[email protected]> * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/pokemon-summary.ts * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update pokemon-summary.ts [Localization(it)] * remove unused code * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: Alexis Faizeau <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Arxxer <[email protected]>
# Conflicts: # src/data/arena-tag.ts
… HA (pagefaultgames#3138) * Prevent evolution causing a swap from the second ability to the HA * Add tests * Update `starter-select-ui-handler.ts`
* More work * More work * Should be finished * Fixed an error in checking target * Moved white herb effect to StatChangePhase, 50% chance of consumption * Added graphics for White Herb * Balance and documentation * Add localization entry for White Herb apply msg * Add new keys to other localization files * German translations Co-authored-by: Jannik Tappert <[email protected]> * Update item sprite atlas * Redo item atlas * Remove whitespace in move.ts * Moved decrement outside conditional * Fix item atlas --------- Co-authored-by: Jannik Tappert <[email protected]>
# Conflicts: # src/locales/pt_BR/config.ts
* Fixed modifiers not displaying on summary screen * Addressed Typedoc issues * Documentation added --------- Co-authored-by: Frutescens <info@laptop>
…e/epic shiny variant and preventing illegal variants from legendary gacha (pagefaultgames#2940) * Changed PokemonSpecies hasVariants function to also include for pokemon with differend forms * Added check to prevent illegal shiny variants from happening if the egg rolls the gacha legendary and has no variants * Simplified variant check. Fixed spelling on unit test * Bugfix for legacy eggs * Removed formIndex variable * Changed unit test * Added new line to unit test function Co-authored-by: flx-sta <[email protected]> --------- Co-authored-by: flx-sta <[email protected]>
…all functionality but keeps the isBeta utils function for future stuff (pagefaultgames#3153)
Co-authored-by: sirzento <[email protected]>
Adri1
reviewed
Jul 28, 2024
returntoice
approved these changes
Jul 28, 2024
Co-authored-by: Lugiad' <[email protected]>
Adri1
approved these changes
Jul 28, 2024
# Conflicts: # src/data/arena-tag.ts # src/data/challenge.ts # src/locales/de/config.ts # src/locales/en/config.ts # src/locales/es/config.ts # src/locales/fr/config.ts # src/locales/it/config.ts # src/locales/ko/config.ts # src/locales/pt_BR/config.ts # src/locales/zh_CN/config.ts # src/locales/zh_TW/config.ts # src/system/game-data.ts # src/ui/menu-ui-handler.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Add the option to localize text of arena tags.
Why am I doing these changes?
All text should be localizable.
What did change?
Screenshots/Videos
Note 1 : I provide just essential test result (to check parameters)
Please comment if you want to check specific case with other languages.
Note 2 : The list below is developed in the original code, but cannot be tested because these do not occur.
arenaOnRemove
reflectOnAdd
lightScreenOnAdd
auroraVeilOnAdd
conditionalProtectOnAdd
tailwindOnAdd
tailwindOnRemove
Click to expand/collapse
How to test the changes?
Manually. (Using overrides.ts.)
Note : message key and possible moves matching list
Click to expand/collapse
Checklist
npm run test)