Getter for unimplemented View.center property on Android #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingwang2011
pushed a commit
to pingwang2011/titanium_mobile
that referenced
this pull request
Jan 10, 2012
TIMOB-6677 Facebook errors with FB.getLoginStatus() being called before FB.init()
jpl-mac
referenced
this pull request
in jpl-mac/titanium_mobile
Mar 22, 2012
Initial modifications to SConstruct to add blackberry
This was referenced Apr 4, 2019
This was referenced Oct 3, 2019
This was referenced Oct 10, 2019
Merged
This was referenced Oct 24, 2019
This was referenced May 14, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for: https://appcelerator.lighthouseapp.com/projects/32238-titanium-mobile/tickets/1775-tiuiview-center-property-not-implemented-on-android-no-warning-in-documentation
Adds a getter implementation for the View center property, works for me in my ad-hoc testing. As with the size property, I'm letting it just return (0, 0) if the native view hasn't been created; have not tested how that case behaves on iPhone, and the docs don't say.
Documentation isn't clear on whether it should be possible to set the property as well, but as I don't need that for my use case I haven't attempted to implement it.