WP Updates #3
Merged
WP Updates #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
In 53c975b, `prepare_attributes_for_render` was changed so that the `$attributes` array that is passed to `render_callback` contains the same keys as what is passed to the block on the front-end. This caused some 'Undefined index' notices in the Latest Comments and Latest Posts blocks. We need to be using `isset()` when using attributes that do not have a default value defined.
This fixes some now-dead links that fell victim to moving and renaming things.
* Avoid showing draft revert message on autosaves * Fix unit tests
* Fix list dom sync * Add e2e test
* Fix RichText rerendering when it shouldn't The prepareEditableTree and onChangeEditableValue function stacks would have a new reference on every render. This prevents that by memoized the stack based on the previous stack and the newly added function. * Rename emptyArray to EMPTY_ARRAY * Add memize as a dependency to annotations package
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
The selector for enabling pointer events was a little too deep, which meant that dragondrop broke. This fixes it, but the columns block retains the simplicity of not allowing you to click/select columns still.
After #8204 was merged, we started using the heading content as the outline item. So if the heading contained custom formats, they were shown in the document outline. Showing the formats in the outline may break the design. This commit makes sure we show the plain text in the hading without any formats.
* Add e2e tests for the format API * Fixes some whitespace issues * Update format-api.test.js * Add missing dependencies to the script registration * Add snapshot to test * Check for custom button, remove extra lines * Change modifier keys used From #11855
* Improve scoping of nested paragraph right-padding rule This addresses feedback in #11757 (comment). The initial issue was that in the default appender, and in empty paragraphs, the plus to add blocks overlaps the placeholder text. The right-padding fixed that. But it bled into other blocks with placeholders, such as the Button block. This PR scopes the rich text rule to only apply to empty paragraphs. The appender was already scoped. * Move paragraph styles to the right place. * Move to editor.scss
* Fixing IE11 flexbox alignment when min-width is set For more info on the fix please see philipwalton/flexbugs#231 * Updating the IE11 alignment fix Updating the fix to use philipwalton/flexbugs#231 (comment) approach for cases with larger cover image text. * Documenting the code * chore: Tweak code style * Add display: block, remove Github ticket mention. * Ignore the IE11 cover image fix in browsers that support flex. * Add a better description of the IE fix. * Fix typo.
Blocks that rely on InnerBlocks have some problems if the user uses the HTML edit function of the block the editor may crash. To solve that on the columns block HTML edit was disabled, this commit applies the same solution to the Media & Text block.
* Wire onReplace and start using it when splitting blocks * Remove onReplace that is still not used in rich-text/index.native.js. It will be used on cut&paste feature. * Remove testing code
Prevent the `components` package styles from overriding the cover block background color. Fixes #12179. Related: [Trac-45279](https://core.trac.wordpress.org/ticket/45279). For details on how to reproduce the issue, see #12179. ## Checklist: - [x] My code is tested. - [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ --> - ~[ ] My code follows the accessibility standards.~ <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ --> - ~[ ] My code has proper inline documentation.~ <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
…reak the editor (#12192)
* Fix exception when editing non-public CPTs - Changes the posts API endpoint to only set `permalink_template` and `generated_slug` when the post is public and queryable. This matches the behaviour in Core. - Changes the `getPermalink()` and `getPermalinkParts()` selectors to return null when there is no `permalink_template`. This fixes an exception on non-public CPTs caused by attempting to parse an undefined `permalink_template`. * Generate docs
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
… editor.scss (#12236) During the reviews of #12187 we found out that the cover block contains some editor specific styles on the front end. This is a problem because we would be transferring bytes on the frontend of websites that are not used at all. This PR just moves this styles to editor.scss so they are loaded only in the editor. ## How has this been tested? I checked that there was no noticeable change on the cover block (and its placeholder).
…s the content. (#11244) If a tag is accepted because of a raw handler transform but unmatched, we do the same as if the tag was not supported so we don't lose the content. The cause of the bug was that even after the removal of the preformatted block the pre tag was still accepted by the code block, but was unmatched if the preformatted was standard none code content.
* Add IE check * typo
This is a test to switch from _Container-Based Builds_ to _Virtual-Machine-Based_ ---- Via: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration Over the next few weeks, we encourage everyone to remove any `sudo: false` configurations from your `.travis.yml`. Soon we will run all projects on the virtual-machine-based infrastructure, the `sudo` keyword will be fully deprecated. The timeline for this migration will be as follows: - 19 November, 2018 - Today we publish this post and are ready to [answer all your questions](https://travis-ci.community/t/combining-the-linux-infrastructures/310/3)! - 28 November, 2018 - We will send a service email to remind folks still using `sudo: false` on recent builds to remind you to migrate. - 03 December, 2018 - We will start randomly sampling projects on both travis-ci.org and travis-ci.com to move them permanently to using the virtual-machine-based infrastructure for all builds. The projects will be migrated incrementally over a few days - 07 December, 2018 - All projects that use a Linux build environment will be fully migrated to using the same Linux infrastructure, which runs builds in virtual-machines. ----
* Expose Undo and Redo components * Make Button look differently when disabled on mobile * Use a local variable to store the aztec height instead of saving it into the block attributes
* Add check for css file before trying to read Mirrors existing trac ticket https://core.trac.wordpress.org/ticket/45288 Fixes #12196 * Use other patch :-)
Fixes #12292. This PR fixes an issue where the block toolbar would cause an image to jump downwards when the wide or fullwide buttons were pressed. Recently as part of a floats refactor, we also refactored how the block toolbar worked. This meant the removal of a floats rule to the toolbar itself, because it was both unnecessary and interfered with adjacent floats. This PR restores that rule, but for wide and fullwide only, fixing the regression.
…agement (#12316) * Expose and wire `onFocus`. Used in Toolbar management methods. * Make sure onFocus is set in PlainText, so it is clear that the listener has to be set. * Wire onFocus on Heading block * Add comments
* Improve top bar tools interaction consistency. * Return early if no rootBlocks.
Wrong argument name broke the "filter by category" functionality in the "Latest Posts" block.
This PR fixes #11585. Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/. This is mainly an issue in deeply nested elements, it seems. This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.
Issue #11069 highlighted that the required dependencies should be called out more in the documentation. This PR adds a line adding additional information on including.
* Editor: Merge meta attributes in getEditedPostAttribute * Editor: Reset getEditedPostAttribute cache by assignment * Editor: Add test for changing getEditedPostAttribute currentPost value * Editor: Remove getEditedPostAttribute merge property cache * Editor: Ensure edits precedence in getEditedPostAttribute * Editor: Add CHANGELOG entry for getEditedPostAttribute merge
This commit adds tests that make sure the block switcher works correctly even when some blocks are removed. This test changes should catch the bug fixed in #12192.
…ter a save draft (#7953) Adds an end 2 end test that verifies we don't regress on issue #7927. The test does the following: Adds a post. Writes aaaa in title and clicks save draft. Presses preview. See the title is correctly previewed as aaaa. Goes back to the editor ands appends bbbb to the title, presses save draft. Presses preview right after the post is saved. Verify that on the preview of the post we see 'aaaabbbb' as the title of the post.
…12345) Don't render a reusable block in the editor or frontend if it is non-published or password protected.
* Polish editor style documentation This includes a section on how to actually enqueue your stylesheet, because this has changed a number of times over the year and hasn't been updated. * Address feedback.
* Try fixing the tab navigation issue * Fix block selection reducer
* Fix README filename * Fix filename * Add the Contributors handbook to the TOC * Rebuild the root manifest with the additional Contributors handbook in the TOC * Rebuild the manifest file with the contributors * Rebuild the manifest file without paths in the 'parent' field as the Importer can't handle that. * Correct the slug of the root-level index * DEBUG: This is the tool I used to re-generate the root-manifest file, altered slightly from a0a6349 * Remove generate.php tool from PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: