Revert back to use the wrong attribute targets for union case declarations. #18342

edgarfgp · 2025-02-26T16:26:00Z

Fixes #18298

Checklist

Test cases added
Release notes entry updated

…t 1 (dotnet#18195) * refactor * tests/FSharp.Compiler.ComponentTests/EmittedIL/ForLoop

…t 2 (dotnet#18196) * More tests - directory attribute improvements * methordresolution

Co-authored-by: Petr <[email protected]>

…18182)

…o-main Merge release/dev17.13 to main

* fix AsyncLazy cancellation * baselines

* otel instrumentation for xunit test runs * wip * sort out deps version conflict * disable for desktop

…ence-packages build 20250110.3 (dotnet#18226) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.24619.1 -> To Version 9.0.0-alpha.1.25060.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…108.5 (dotnet#18227) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk From Version 9.0.0-beta.24623.3 -> To Version 9.0.0-beta.25058.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <[email protected]>

…8177)

… Generic arguments (dotnet#17877) * tests * code * baseline * fantomas * release notes * ilverify baselines * Update tests/FSharp.Compiler.ComponentTests/Conformance/LexicalAnalysis/SymbolicOperators.fs Yeah the comments are pointless. Co-authored-by: Tomas Grosup <[email protected]> * Feedback pt 1 * temp * tests * release notes * debug * Update DEVGUIDE.md Co-authored-by: Petr <[email protected]> --------- Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: Petr <[email protected]>

…nager/DependencyProvider.fs and refactored. (dotnet#18207) * /Compiler/TypedTree/TypedTreePickle.fs refactored. "#if" directive around nullness removed from src Related: dotnet#18061 (partially addresses) - [x] Release notes entry updated: in `docs/release-notes/.FSharp.Compiler.Service/9.0.200.md`, * try 2 * refactoring * . * . * lets hope this works * . * fantomas tried with a bit of tricks DependencyProvider.fs * fantomas ignore * unformat --------- Co-authored-by: Petr <[email protected]>

…115.2 (dotnet#18240) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk From Version 9.0.0-beta.25058.5 -> To Version 9.0.0-beta.25065.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* simplify tests dependencies * OverallHintExperienceTests

…ence-packages build 20250116.1 (dotnet#18242) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.25060.3 -> To Version 9.0.0-alpha.1.25066.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Expose missing constraints * Updated release notes

…ure typar (dotnet#18234)

…d `urlFormat` properties (dotnet#18224)

…o-main Merge release/dev17.13 to main

…otnet#18205)

…t CoarcesTo constraints (dotnet#18266)

…ds and read it in fslib reflection (dotnet#18274)

…#18291) * Add missing project reference from FSharpSuite to fsc project * fix

* Symbols: add FSharpAssembly.IsFSharp * Surface area * Release notes

…ion and vice versa (dotnet#18186)

…uagePrimitves into instance method calls (dotnet#18296) * Handle |null types when optimizing away eqals/hash/compare from function call to instance method * Set propper test assert * fantomas and notes * remove comment

…net#18299)

Contributes to dotnet/sdk#46642 NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

* trace test run activity * declutter StackGuard.Guard traces * add otel to debug vsix * ref otel in debug only * delay tags allocation * fix opens * format * better naming

* Cancellable: fix leaking cancellation token * Release notes Update docs/release-notes/.FSharp.Compiler.Service/9.0.300.md * Set Cancellable.Token in transparent compiler * Review fixes * Move setting the token * Fantomas * Transparent compiler * il bsl --------- Co-authored-by: Petr <[email protected]>

…211.5 (dotnet#18310) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk From Version 9.0.0-beta.25077.4 -> To Version 9.0.0-beta.25111.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…otnet#18300) * Resolve `nameof` in `nameof<'T>` * Resolve `nameof` in `match … with nameof ident -> …` * Add `nameof` classification tests * Update release notes * Might as well make them compilable * Show `nameof` as keyword in `nameof<…>` even when the type parameter is invalid * Touchup

* simplify * add comment * already shipped

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted. Resolve the one warning that got emitted when building the repository in non-source-only mode.

…tions.

github-actions · 2025-02-26T16:26:41Z

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description

src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

T-Gro · 2025-02-26T17:46:19Z

@edgarfgp , thanks for handling this.
Please target this to 17.13 version, this PR is worth being a servicing patch for NET9.

(it will then flow to main+17.14 out of the servicing branch)

T-Gro

@edgarfgp :

What happened now is that it took all commits from your local main clone and wants to push those onto dev17.13.

Your change should rather be rebased on top of dev17.13 (or, since the actual change is so small, can also be dona from scratch on the dev17.13 branch directly).

I will reject the PR to avoid accidental merging of 67 commits into a servicing branch :)

majocha and others added 30 commits January 6, 2025 21:16

run type provider tests in sequence (dotnet#18200)

ded0349

Improve directory attribute refactor - Break up PR dotnet#18161 - Par…

6ce0691

…t 1 (dotnet#18195) * refactor * tests/FSharp.Compiler.ComponentTests/EmittedIL/ForLoop

src/Compiler/TypedTree/TypedTreePickle.fs and refactored. (dotnet#18203)

73b8cbb

Improve directory attribute refactor - Break up PR dotnet#18161 - Par…

a310d1d

…t 2 (dotnet#18196) * More tests - directory attribute improvements * methordresolution

Merge branch 'main' into merges/release/dev17.13-to-main

7c8705f

Even more tests (dotnet#18197)

26f710b

Co-authored-by: Petr <[email protected]>

remove unnecessary overrides (dotnet#18208)

23bb605

Show obsolete warnings/errors when used with unit of measure (dotnet#…

9ac324d

…18182)

Merge pull request dotnet#18214 from dotnet/merges/release/dev17.13-t…

88463f8

…o-main Merge release/dev17.13 to main

Versioning for 17.14 and 9.0.300 (dotnet#18222)

77e7e08

Fix AsyncLazy cancellation (dotnet#18211)

b204f87

* fix AsyncLazy cancellation * baselines

OpenTelemetry instrumentation for xUnit tests (dotnet#18230)

dfffae6

* otel instrumentation for xunit test runs * wip * sort out deps version conflict * disable for desktop

Make nullness equivalent warning message clearer. (dotnet#18172)

ec2b3d9

Fix fsi auto-loading of script file inside NuGet package. (dotnet#1…

c350a41

…8177)

Enable OpenTelemetry for Desktop target in xUnit tests (dotnet#18233)

9b34544

Set Cancellable.token from async computation (dotnet#18238)

8473ce6

Simplify Dependencies a tad (dotnet#18236)

7c598f4

* simplify tests dependencies * OverallHintExperienceTests

Added missing type constraints in FCS (dotnet#18241)

72ab794

* Expose missing constraints * Updated release notes

Fix internal error when missing measure attribute in an unsolved meas…

5bfbc6d

…ure typar (dotnet#18234)

Update Obsolete attribute checking to account for diagnosticId an…

4b676b4

…d `urlFormat` properties (dotnet#18224)

Update azure-pipelines.yml

8660de9

Merge branch 'main' into merges/release/dev17.13-to-main

ba6d854

Merge pull request dotnet#18248 from dotnet/merges/release/dev17.13-t…

686dcab

…o-main Merge release/dev17.13 to main

Remove FSharpProjectOptions from Transparent Compiler check results (d…

9800899

…otnet#18205)

T-Gro and others added 18 commits February 4, 2025 14:03

Bugfix :: Flexible types should subsume nullable version of equivalen…

10b812b

…t CoarcesTo constraints (dotnet#18266)

Bugfix:: Add missing codegen for mapping of overlapped struct DU fiel…

adb02dc

…ds and read it in fslib reflection (dotnet#18274)

Add missing project reference from FSharpSuite to fsc project (dotnet…

5ef029b

…#18291) * Add missing project reference from FSharpSuite to fsc project * fix

Symbols: Add FSharpAssembly.IsFSharp (dotnet#18290)

674e099

* Symbols: add FSharpAssembly.IsFSharp * Surface area * Release notes

Bugfix :: Nullness in signature file is not considered by implementat…

841ba8e

…ion and vice versa (dotnet#18186)

Only build the Microsoft.FSharp.Compiler.sln solution in the VMR (dot…

ad29712

…net#18299)

Consolidate .Using and |null in builders (dotnet#18292)

b64ea2b

Add support for C# Experimental attribute (dotnet#18253)

8e773e7

React to NuGet package pruning warnings (dotnet#18304)

7866d66

Contributes to dotnet/sdk#46642 NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

More OpenTelemetry changes (dotnet#18246)

5d0812f

* trace test run activity * declutter StackGuard.Guard traces * add otel to debug vsix * ref otel in debug only * delay tags allocation * fix opens * format * better naming

Cancellable: hide UsingToken and simplify inlined run (dotnet#18309)

2ea701e

* simplify * add comment * already shipped

Contributes to dotnet/sdk#46829 (dotnet#18318)

898c6c7

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted. Resolve the one warning that got emitted when building the repository in non-source-only mode.

do not share (dotnet#18326)

a2f2b00

Revert back to use the wrong attribute targets for union case declara…

40c2045

…tions.

update tests

1d1266f

edgarfgp force-pushed the fix-18298 branch from d7b7441 to 1d1266f Compare February 26, 2025 17:58

edgarfgp changed the base branch from main to release/dev17.13 February 27, 2025 11:01

release notes

0672973

edgarfgp marked this pull request as ready for review February 27, 2025 13:57

edgarfgp requested review from a team as code owners February 27, 2025 13:57

edgarfgp requested a review from T-Gro February 27, 2025 13:57

T-Gro requested changes Feb 27, 2025

View reviewed changes

edgarfgp closed this Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert back to use the wrong attribute targets for union case declarations. #18342

Revert back to use the wrong attribute targets for union case declarations. #18342

edgarfgp commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading

T-Gro commented Feb 26, 2025

T-Gro left a comment

Revert back to use the wrong attribute targets for union case declarations. #18342

Revert back to use the wrong attribute targets for union case declarations. #18342

Conversation

edgarfgp commented Feb 26, 2025 • edited Loading

Checklist

github-actions bot commented Feb 26, 2025 • edited Loading

❗ Release notes required

T-Gro commented Feb 26, 2025

T-Gro left a comment

Choose a reason for hiding this comment

edgarfgp commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025 •

edited

Loading